Skip to content

Rename delimeter -> delimiter in env_vars and external_secrets#9409

Merged
captainsafia merged 1 commit intowarpdotdev:masterfrom
BennyWaitWhat:bennywaitwhat/rename-delimeter-to-delimiter
Apr 30, 2026
Merged

Rename delimeter -> delimiter in env_vars and external_secrets#9409
captainsafia merged 1 commit intowarpdotdev:masterfrom
BennyWaitWhat:bennywaitwhat/rename-delimeter-to-delimiter

Conversation

@BennyWaitWhat
Copy link
Copy Markdown
Contributor

Description

Renames a misspelled identifier (delimeter -> delimiter) across two modules. Pure rename: 2 files, +9/-9 lines, no behavioral change.

app/src/env_vars/mod.rs - 6 changes:

  • pub fn export_variables(&self, delimeter: &str, ...) -> delimiter (parameter name)
  • Internal call site
  • Private serialize_variables_internal(..., delimeter: &str, ...) parameter
  • Three doc comments referencing the parameter

app/src/external_secrets/mod.rs - 3 changes:

  • static ref WARP_SECRET_DELIMETER -> WARP_SECRET_DELIMITER (the constant identifier)
  • Two usages of the constant

What is intentionally preserved

The string literal value "/warp-secret-delimeter/" on line 22 is kept as-is. It is the runtime separator embedded in the lpass --format=%an{}%ai command and split back out of lpass's output (line.split(*WARP_SECRET_DELIMITER)). Changing the value would mean output emitted with one delimiter is parsed with another, breaking LastPass secret enumeration. Only the Rust identifier name is corrected; the on-the-wire token is unchanged.

Caller analysis

All three external call sites of export_variables (in drive/index.rs, drive/export.rs, terminal/input.rs) use positional arguments. Rust does not have named arguments, so the parameter rename is invisible to callers and breaks nothing.

Related

The comment // Used as a delimeter to separate metadata on line 20 of external_secrets/mod.rs is deliberately left for PR #9404 (the round-3 typo bundle), which already includes that fix. Different lines, no conflict.

Testing

Pure identifier rename; no logic touched. The string-literal preservation note above is the only correctness-relevant detail.

Agent Mode

  • Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Fixes a misspelled identifier across two modules:
- `app/src/env_vars/mod.rs`: `delimeter` parameter and uses (5x) and one comment.
- `app/src/external_secrets/mod.rs`: `WARP_SECRET_DELIMETER` constant name (3x).

The string literal value `"/warp-secret-delimeter/"` in external_secrets is
intentionally preserved - it is the runtime separator passed to lpass via
`--format` and parsed back from its output, so changing the value would break
secret enumeration. Only the constant identifier is renamed.

All call sites of `export_variables(...)` use positional arguments, so the
parameter rename has no effect on callers.
@cla-bot cla-bot Bot added the cla-signed label Apr 29, 2026
@oz-for-oss
Copy link
Copy Markdown
Contributor

oz-for-oss Bot commented Apr 29, 2026

@BennyWaitWhat

I'm starting a first review of this pull request.

You can view the conversation on Warp.

I approved this pull request. No matching stakeholder was found for the changed files, so no human reviewers were requested.

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

Copy link
Copy Markdown
Contributor

@oz-for-oss oz-for-oss Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overview

Renames the misspelled delimeter identifier to delimiter in environment variable serialization and external secrets while preserving the LastPass delimiter string literal.

Concerns

  • No blocking correctness or security concerns found in the changed lines.

Verdict

Found: 0 critical, 0 important, 0 suggestions

Approve

Comment /oz-review on this pull request to retrigger a review (up to 3 times on the same pull request).

Powered by Oz

@captainsafia captainsafia merged commit e9ff932 into warpdotdev:master Apr 30, 2026
34 checks passed
@captainsafia captainsafia added the external-contributor Indicates that a PR has been opened by someone outside the Warp team. label Apr 30, 2026 — with Warp Dev Github Integration
zerx-lab pushed a commit to zerx-lab/warp that referenced this pull request May 3, 2026
…arpdotdev#9409)

## Description

Renames a misspelled identifier (`delimeter` -> `delimiter`) across two
modules. Pure rename: 2 files, +9/-9 lines, no behavioral change.

**`app/src/env_vars/mod.rs`** - 6 changes:
- `pub fn export_variables(&self, delimeter: &str, ...)` -> `delimiter`
(parameter name)
- Internal call site
- Private `serialize_variables_internal(..., delimeter: &str, ...)`
parameter
- Three doc comments referencing the parameter

**`app/src/external_secrets/mod.rs`** - 3 changes:
- `static ref WARP_SECRET_DELIMETER` -> `WARP_SECRET_DELIMITER` (the
constant *identifier*)
- Two usages of the constant

### What is intentionally preserved

The **string literal value** `"/warp-secret-delimeter/"` on line 22 is
**kept as-is**. It is the runtime separator embedded in the `lpass
--format=%an{}%ai` command and split back out of lpass's output
(`line.split(*WARP_SECRET_DELIMITER)`). Changing the value would mean
output emitted with one delimiter is parsed with another, breaking
LastPass secret enumeration. Only the Rust identifier name is corrected;
the on-the-wire token is unchanged.

### Caller analysis

All three external call sites of `export_variables` (in
`drive/index.rs`, `drive/export.rs`, `terminal/input.rs`) use positional
arguments. Rust does not have named arguments, so the parameter rename
is invisible to callers and breaks nothing.

### Related

The comment `// Used as a delimeter to separate metadata` on line 20 of
`external_secrets/mod.rs` is deliberately left for PR warpdotdev#9404 (the round-3
typo bundle), which already includes that fix. Different lines, no
conflict.

## Testing

Pure identifier rename; no logic touched. The string-literal
preservation note above is the only correctness-relevant detail.

## Agent Mode

- [ ] Warp Agent Mode - This PR was created via Warp's AI Agent Mode

Co-authored-by: BennyWaitWhat <BennyWaitWhat@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed external-contributor Indicates that a PR has been opened by someone outside the Warp team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants